Skip to content

Fix tests:check-direct-dependency-use command not working with plugins when test running on Github #22012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michalkleiner merged 1 commit into from
Mar 11, 2024
Merged

Fix tests:check-direct-dependency-use command not working with plugins when test running on Github #22012

michalkleiner merged 1 commit into from
Mar 11, 2024

Conversation

@AltamashShaikh
Copy link
Contributor

@AltamashShaikh AltamashShaikh commented Mar 11, 2024

Description:

This PR worked fine locally, but when the PR was merged and we tried using it with plugins the tests started failing and on debugging we were able to find the cause and fix the same.

Fixes: #PG-3334

Review

@AltamashShaikh AltamashShaikh added the Needs Review PRs that need a code review label Mar 11, 2024
@michalkleiner michalkleiner merged commit 894d952 into 5.x-dev Mar 11, 2024
@michalkleiner michalkleiner deleted the PG-3334-fix-dependency-check-command branch March 11, 2024 03:30
@michalkleiner michalkleiner added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Mar 11, 2024
@michalkleiner michalkleiner added this to the 5.1.0 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@michalkleiner michalkleiner michalkleiner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@AltamashShaikh @michalkleiner