Skip to content

Conversation

@AltamashShaikh
Copy link
Contributor

@AltamashShaikh AltamashShaikh commented Feb 29, 2024

Description:

Added tests to check direct use of core dependencies
Fixes: #PG-3272
Depends on: matomo-org/matomo#21969

Review

Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Local testing worked as expected 👍

@AltamashShaikh
Copy link
Contributor Author

@snake14 Strange that all the false positives are not being reported on Github

@snake14
Copy link
Contributor

snake14 commented Mar 3, 2024

@snake14 Strange that all the false positives are not being reported on Github

Yeah. It's a little concerning and makes we wonder if it will catch legitimate dependency issues.

@AltamashShaikh
Copy link
Contributor Author

@snake14 I found why its not working for plugins and looks like we need to update core command, hopefully that should be done quickly

@AltamashShaikh
Copy link
Contributor Author

@snake14 It works now, after the recent PR in core was merged.

@AltamashShaikh AltamashShaikh merged commit 36ba951 into 5.x-dev Mar 11, 2024
@AltamashShaikh AltamashShaikh deleted the PG-3272-check-direct-dep branch March 11, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants