-
Notifications
You must be signed in to change notification settings - Fork 29
Added tests to check direct use of core dependencies, #PG-3272 #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Local testing worked as expected 👍
|
@snake14 Strange that all the false positives are not being reported on Github |
Yeah. It's a little concerning and makes we wonder if it will catch legitimate dependency issues. |
|
@snake14 I found why its not working for plugins and looks like we need to update core command, hopefully that should be done quickly |
|
@snake14 It works now, after the recent PR in core was merged. |
Description:
Added tests to check direct use of core dependencies
Fixes: #PG-3272
Depends on: matomo-org/matomo#21969
Review