This repository was archived by the owner on Jul 21, 2025. It is now read-only.
Add TTL support for FCM notifications#312
Open
Fizzadar wants to merge 1 commit intomatrix-org:mainfrom
Open
Conversation
Contributor
|
|
squahtx
reviewed
Jul 11, 2022
Contributor
squahtx
left a comment
squahtx
left a comment
There was a problem hiding this comment.
The Notification dict is specced and it's impolite for us to add extra fields to it.
I think we're allowed to put pusher-specific fields in device.data, so that could be an option?
squahtx
added
the
X-Awaiting-Changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.