feat: add autoApprove to generated MCP config (fixes #74)#170
Merged
mergify[bot] merged 3 commits intomatrixorigin:mainfrom Apr 7, 2026
Merged
feat: add autoApprove to generated MCP config (fixes #74)#170mergify[bot] merged 3 commits intomatrixorigin:mainfrom
mergify[bot] merged 3 commits intomatrixorigin:mainfrom
Conversation
memoria init --tool <kiro|cursor|claude|...> now includes an autoApprove array in the generated mcp.json entry covering all Memoria MCP tools. Without this, editors such as Kiro and Cursor prompt the user for manual approval on every single memory operation, defeating the purpose of seamless ambient memory. The user has already established trust by installing Memoria and providing an API token, so auto-approving Memoria's own read/write tools is consistent with that trust. Editors that do not recognise the autoApprove field ignore it, so existing workflows are unaffected. Includes a unit test that asserts: - autoApprove is present and non-empty in both remote and embedded mode - core tools (memory_store, memory_retrieve, memory_search, memory_purge) are always listed
nandanadileep
requested review from
XuPeng-SH,
aptend and
gouhongshen
as code owners
XuPeng-SH
approved these changes
Apr 6, 2026
Collaborator
XuPeng-SH
left a comment
XuPeng-SH
left a comment
There was a problem hiding this comment.
Thanks for the PR! Your help is much appreciated.
Merge Queue Status
This pull request spent 1 hour 39 seconds in the queue, with no time running CI. Required conditions to merge
ReasonThe merge conditions cannot be satisfied due to checks timeout HintYou may have to fix your CI before adding the pull request to the queue again. If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again. |
Merge Queue Status
This pull request spent 1 hour 12 seconds in the queue, with no time running CI. Required conditions to merge
ReasonThe merge conditions cannot be satisfied due to checks timeout HintYou may have to fix your CI before adding the pull request to the queue again. If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again. |
Merge Queue Status
This pull request spent 10 seconds in the queue, including 1 second running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #74.
Problem
memoria init --tool <kiro|cursor|claude>generates anmcp.jsonentry without anautoApprovelist. As a result, editors like Kiro and Cursor show a manual approval prompt for every single memory operation — even in Autopilot mode. This defeats the purpose of ambient, seamless memory.The user has already established trust by installing Memoria and providing an API token. Requiring per-call approval for low-risk read/write operations on the user's own memory store creates unnecessary friction.
Change
mcp_entry()now includes anautoApprovearray listing all 34 Memoria MCP tools. The array is written into the generatedmcp.jsonfor every target editor (Kiro, Cursor, Claude Code, OpenCode, Codex):{ "mcpServers": { "memoria": { "command": "memoria", "args": ["mcp", "--tool", "kiro", ...], "autoApprove": [ "memory_store", "memory_retrieve", "memory_search", ... ] } } }Editors that do not recognise
autoApproveignore the field, so existing configs and workflows are unaffected. If an existingmcp.jsonis updated by re-runningmemoria init, theautoApprovefield is written alongside the other config.Test plan
mcp_entry_includes_auto_approve— assertsautoApproveis present and non-empty in both remote and embedded mode, and that core tools (memory_store,memory_retrieve,memory_search,memory_purge) are always listedmemoria init --tool kiroand confirm.kiro/settings/mcp.jsoncontainsautoApprovememoria init --tool cursorand confirm.cursor/mcp.jsoncontainsautoApprove