This repository was archived by the owner on Mar 19, 2022. It is now read-only.
Enable support for macOS 10.12 Sierra#498
Open
CGamesPlay wants to merge 1 commit intomatschaffer:masterfrom
Open
Enable support for macOS 10.12 Sierra#498CGamesPlay wants to merge 1 commit intomatschaffer:masterfrom
CGamesPlay wants to merge 1 commit intomatschaffer:masterfrom
Conversation
Collaborator
|
@CGamesPlay I think the tests that fail have been fixed on the master branch. So I think if you would rebase your branch on the current master branch, your PR should have successful test runs. |
CGamesPlay
force-pushed
the
master
branch
2 times, most recently
from
fa44870 to
f813f54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since SIP landed,
/usr/local/binhas been removed from the default paths. You can confirm this withssh new-sierra-host env, and inspecting the PATH. To fix this, I needed to ensure that/usr/local/binis added via.bashrcfor the non-admin running user.Additionally, the
TMPDIRon macOS is readable only by the user who created the file. In chef's case, this means root. This means that no chefscriptresource that runs as a user can actually succeed, because the interpreter can't read the script file. I added a line to solo.rb to set theTMPDIRto something world-readable.