Implemented support for symmetric encryption and decryption#322
Open
GlitchedPolygons wants to merge 6 commits intomattosaurus:masterfrom
Open
Implemented support for symmetric encryption and decryption#322GlitchedPolygons wants to merge 6 commits intomattosaurus:masterfrom
GlitchedPolygons wants to merge 6 commits intomattosaurus:masterfrom
Conversation
Author
|
@mattosaurus FYI I bumped the dotnet version in the unit tests project to v10 (since that's the only SDK that I have installed on my machine), but let me know if I should revert that if you'd prefer staying on v8. |
…::AddVersionHeader (set default to true to retain previous PgpCore's behaviour). This is associated with mattosaurus#193.
Owner
|
Great. Thanks for this, I'll take a look later. I think as long as it's targeted at .NET 10 and standard 2 then we should be good so happy to increase the version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thought this was missing in this otherwise awesome codebase, so I gave it a shot :)
Tests still succeed and I've added an additional key type in the test data's KeyType enum, but I also tested it manually using Kleopatra: works on my machine 🥲
Cheers <3