Obtain baseDir through more portable means.#27
Open
aeriksson wants to merge 1 commit intomattpap:masterfrom
Open
Obtain baseDir through more portable means.#27aeriksson wants to merge 1 commit intomattpap:masterfrom
baseDir through more portable means.#27aeriksson wants to merge 1 commit intomattpap:masterfrom
Conversation
Author
|
This fixes #26 |
`readlink -f` does not work on OS X. This commit replaces the use of `readlink -f` with something more portable. While this approach may not always fully resolve symlinks, it should be fine since java seems to resolve symlinks.
|
I tried this but doesn't seem to resolve the issue. I still get the same error #26 |
Author
|
@rakeshchalasani: That shouldn't be possible (the error is |
|
Sorry about that, I changed a couple of things too many before I tried this patch. Building from your repo works fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readlink -fdoes not work on OS X.This commit replaces the use of
readlink -fwith something moreportable.
While this approach may not always fully resolve symlinks, it should be
fine since java seems to resolve symlinks.