AysyncHTTPClient support for linux#143
Open
JonasProgrammer wants to merge 3 commits intomattt:mattt/gate-linux-urlsessionfrom
Open
AysyncHTTPClient support for linux#143JonasProgrammer wants to merge 3 commits intomattt:mattt/gate-linux-urlsessionfrom
JonasProgrammer wants to merge 3 commits intomattt:mattt/gate-linux-urlsessionfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #127, the current workaround is not really feasible for async applications.
This PR includes an AsyncHTTPClient trait that does the following:
When untraited, the library should work as-is. Whith the trait active, the interface is changed to consume an HTTPClient as the session type.
I tried to change the business logic as little as possible, mostly implementing URLSession's extensions for HttpClient.