QtLocationPlugin: Split CacheWorker & CacheDatabase

[HTRamsey]

Splits the worker and sql database management for cleaner code

[Copilot]

Pull Request Overview

This PR implements a refactoring of the QtLocationPlugin map cache system to split database and worker functionality for cleaner code organization. The main purpose is to extract database operations into a separate class (QGCTileCacheDatabase) while maintaining the existing worker thread architecture.

Key changes include:

• Introduction of a new QGCTileCacheDatabase class to handle all SQL operations
• Refactoring of QGCCacheWorker to use the new database class instead of direct SQL
• Modernization of code style including enum classes, better error handling, and improved const-correctness

Reviewed Changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/UI/AppSettings/MapSettings.qml	Updates enum references to use scoped enum syntax
src/QtLocationPlugin/QGCTileCacheDatabase.h	Defines new database abstraction class with structured data types
src/QtLocationPlugin/QGCTileCacheDatabase.cpp	Implements comprehensive database operations with error handling
src/QtLocationPlugin/QGCTileCacheWorker.h	Refactored worker header to use database abstraction
src/QtLocationPlugin/QGCTileCacheWorker.cpp	Updated worker implementation to delegate to database class
Various other files	Code style improvements, enum updates, and header organization

Comments suppressed due to low confidence (2)

src/QtLocationPlugin/QGCTileCacheDatabase.cpp:1

• Using std::make_unique followed by release() defeats the purpose of smart pointers. Either use raw new directly or modify the API to accept std::unique_ptr to maintain RAII benefits.

/****************************************************************************

src/QtLocationPlugin/QGCTileCacheWorker.cpp:1

• Inconsistent member access - mixing direct member access (hash, format, type) with what appears to be a method call (img). All should use consistent accessor patterns.

/****************************************************************************

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}