Hexagon: consistent _f16/_f32 naming #28
Conversation
Refactor Hexagon backend HVX headers and dependent htp code to consistently use `_f16` and `_f32` suffixes instead of `_fp16` and `_fp32` for function names and related variables. This unifies the naming convention across the backend. - Rename `hvx_vec_*_fp32` to `hvx_vec_*_f32` (e.g., `splat`, `exp`, `tanh`). - Rename `hvx_vec_*_fp16` to `hvx_vec_*_f16`. - Rename copy and loop helpers (e.g., `hvx_copy_fp32_aa` -> `hvx_copy_f32_aa`). - Update internal implementation functions in `act-ops.c`, `matmul-ops.c`, etc. - Update usages in `.c` files to match new header definitions.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Renamed functions in
ggml/src/ggml-hexagon/htp/hvx-*.hand updated usages inggml/src/ggml-hexagon/htp/*.cto replace_fp16/_fp32with_f16/_f32. Verified via grep and partial text analysis. Compilation requires Hexagon SDK and was skipped (expected failure).PR created automatically by Jules for task 730959513905403024 started by @max-krasnyansky