FIX: Cannot read property 'toUpperCase' of undefined#10
Open
henrikra wants to merge 2 commits intomaximalism2:masterfrom
Open
FIX: Cannot read property 'toUpperCase' of undefined#10henrikra wants to merge 2 commits intomaximalism2:masterfrom
henrikra wants to merge 2 commits intomaximalism2:masterfrom
Conversation
Contributor
|
Cool, I can help test out soon @henrikra. |
Author
|
@TheTekton Did you managed to test this out? :D |
|
@henrikra @TheTekton Any word on this. Looks like this is the key to getting master set up for a release with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To cause for this was that
filenamewas alwaysundefined. I am pretty sure this is the right fix since I have tested the script on OSX with and without target folder. I also added implementation offorEachsince for some reasonforEachwas used like a global function but node threw an error for that. Can you guys @TheTekton @necinc confirm this? :)Fixes #7