Conversation
Member
oschwald
commented
Apr 24, 2025
oschwald
commented
- Ignore clangd conf file
- Fix license config deprecation warnings
- Correctly handle null check of entry_data_list
They switched to a new format for licenses. See: https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license
I suspect at some point, we were passing in `entry_data_list` as a `MMDB_entry_data_list_s *`, which is what we do in other extensions, but that was refactored to `MMDB_entry_data_list_s **` for reasons I do not recall, and the loop check was never updated appropriately. This never caused an actual issue as we also have the size check. However, it could potentially lead to a segfault on a corrupt or otherwise invalid database.
Previously, it wasn't using the right setuptools version. We have a separate issue for switch our tox configuration over to tox-uv.
horgh
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.