ENG-4369: Update golangci-lint to 2.11.3 via mise

[oschwald]

Summary

• Pin golangci-lint 2.11.3 via mise.toml + mise.lock
• Replace golangci-lint GHA with jdx/mise-action + direct run
• Fix lint failures with v2.11.3 (removed 6 stale //nolint:gosec directives)

Test plan

• golangci-lint run ./... passes locally
• CI passes on PR

🤖 Generated with Claude Code

[github-actions]

Modver result

This report was generated by Modver,
a Go package and command that helps you obey semantic versioning rules in your Go module.

This PR does not require a change in your module’s version number.
(You might still consider bumping the patchlevel anyway.)

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the golangci-lint version to 2.11.3 and integrating it with the mise tool manager. This ensures consistent linting across environments and resolves linting failures introduced by the new version. The changes also streamline the CI workflow by using jdx/mise-action.

Highlights

• golangci-lint Update: The pull request updates golangci-lint to version 2.11.3 using mise for tool management.
• Mise Configuration: It introduces mise.toml and mise.lock files to pin the golangci-lint version and manage dependencies.
• Linting Fixes: The update includes the removal of stale //nolint:gosec directives to address linting failures with the new version.
• GHA Workflow: Replaces the existing golangci-lint GitHub Action with jdx/mise-action for direct execution.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/golangci-lint.yml

Activity

• Updated golangci-lint to v2.11.3
• Added mise configuration files for tool management
• Removed obsolete nolint directives
• Switched to jdx/mise-action for linting in GHA

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to update golangci-lint and manage tool versions using mise. However, the current configuration in mise.toml uses latest for both Go and golangci-lint, which has resulted in the mise.lock file pointing to non-existent versions (1.26.1 for Go and 2.11.3 for golangci-lint). This is a critical issue that will cause the build to fail because the tool binaries cannot be downloaded. I have added review comments on mise.toml with suggestions to pin to specific, existing versions. After applying these changes, the mise.lock file will need to be regenerated. Once the tool versions are corrected, please also re-verify that the removed //nolint:gosec directives are indeed stale with the correct version of golangci-lint.

[gemini-code-assist]

Using latest for the Go toolchain has resolved to version 1.26.1 in mise.lock, which is a non-existent version of Go. This will cause mise install to fail as the download URL will result in a 404 error. Please pin to a specific, existing version of Go, for example the latest stable version.

Suggested change

	go = "latest"
	go = "1.22"

[gemini-code-assist]

Using latest for golangci-lint has resolved to version 2.11.3 in mise.lock. This version does not appear to exist in the official golangci/golangci-lint repository, and its download URL will fail. The latest available version at the time of this review is 1.58.1. Please pin to an existing version.

Suggested change

	"github:golangci/golangci-lint" = "latest"
	"github:golangci/golangci-lint" = "1.58.1"