Fixing file location on package.json #413
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #413 +/- ##
=======================================
Coverage 82.56% 82.56%
=======================================
Files 14 14
Lines 562 562
=======================================
Hits 464 464
Misses 98 98Continue to review full report at Codecov.
|
jaythomas
reviewed
Jul 19, 2017
| @@ -1,4 +1,8 @@ | |||
| (function() { | |||
| if (typeof FastClick === 'undefined') { | |||
| throw new Error('mobile-angular-ui\'s JavaScript requires FastClick') | |||
There was a problem hiding this comment.
CI is failing because you forgot a semi-colon.
|
I think re-building the dist/ folder as part of the commit is a bad idea because the contents of your dist may not necessarily reflect all the commits that have gone into master since your generated dist was created. It also pollutes the diff when trying to do code reviews or check commits in the git history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.