Skip to content

Conversation

@Muhnad
Copy link

@Muhnad Muhnad commented Sep 30, 2020

@mciastek
Copy link
Owner

mciastek commented Oct 4, 2020

Thank you for submitting this PR. I think that implementation of reduced motion support is not yet ready for sal.js. We need to check for reduced motion on load, but also when it changes. This requires adding a change listener. In my opinion, it's too much for such small library. Additionally, nothing stops a developer adding such kind of support by themselves. There's a required API (disable and enable methods), so this feature can be implemented outside of sal.

I do like your changes in README, so I'd like to ask you to create a separate PR with documentation changes. I appreciate it. Thank you!

@Muhnad
Copy link
Author

Muhnad commented Oct 15, 2020 via email

@mciastek mciastek mentioned this pull request Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants