variable "sigterm" must be volatile sig_atomic_t #223
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signals handlers can only read/write to volatile sig_atomic_t variables or atomic lock-free ones. Anything else results in undefined behaviour. Signed-off-by: Cristian Rodríguez <cristian@rodriguez.im>
crrodriguez
force-pushed
the
volatile_sigatomic
branch
from
4825a32 to
29d6828
Compare
Contributor
Author
|
checkpatch is wrong here because this is an special case .. "the behavior is undefined if ... |
Member
|
@crrodriguez thanks for the fix. |
Contributor
Author
|
It is just UB if you don't do this, that's all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signals handlers can only read/write to volatile sig_atomic_t variables or atomic lock-free ones.
Anything else results in undefined behaviour.