Skip to content

Conversation

@rebloor
Copy link
Contributor

@rebloor rebloor commented Oct 23, 2025

Summary

Add details of the data_collection_permissions property of gecko to the browser_specific_settings manifest key. This feature was implemented in Bug 1954524 Add support for data collection permissions in the manifest.

Related issues

Fixes #28211

Related MDM documentation included in PR TBC

@rebloor rebloor requested a review from dotproto October 23, 2025 17:17
@rebloor rebloor self-assigned this Oct 23, 2025
@rebloor rebloor added the data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Oct 23, 2025
@rebloor rebloor requested review from Rob--W and willdurand October 23, 2025 17:18
@github-actions github-actions bot added the size:m [PR only] 25-100 LoC changed label Oct 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

@rebloor
Copy link
Contributor Author

rebloor commented Oct 23, 2025

@willdurand I noticed that the change was released in 139 ,but the page on Extension Workshop states that it's available for 140 (and 142 for Android). Which version should be followed here and on the MDN release note?

@dotproto
Copy link
Contributor

@willdurand, please correct me if I'm wrong, but I believe AMO's linter enforces the 140 requirement. While technically the code exists in Firefox 139 does support it, the official publishing flow doesn't.

@willdurand
Copy link
Member

The desktop UI was finalized in 140 so let's go with that.

@willdurand willdurand removed the request for review from Rob--W October 24, 2025 07:32
@rebloor rebloor requested a review from willdurand October 24, 2025 16:29
@github-actions github-actions bot added size:s [PR only] 7-24 LoC changed and removed size:m [PR only] 25-100 LoC changed labels Oct 24, 2025
Copy link
Member

@willdurand willdurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

},
"edge": "mirror",
"firefox": {
"version_added": "140"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version_added": "140"
"version_added": "140",
"notes": "Supports `required` and `optional`."

"version_added": "140"
},
"firefox_android": {
"version_added": "142"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version_added": "142"
"version_added": "142",
"notes": "Supports `required` and `optional`."

@rebloor
Copy link
Contributor Author

rebloor commented Oct 27, 2025

@willdurand I've added details of the optional and required properties to the documentation. Therefore, in line with what we normally document in the BCD, I don't think we need the note about them here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions size:s [PR only] 7-24 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

webextensions.manifest.browser_specific_settings - data_collection_permissions

3 participants