setHTML and friends - fixes for data-attributes. #41715
Merged
+48
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
|
Preview URLs
(comment last updated: 2025-10-28 07:18:08) |
That's ironic. |
sideshowbarker
approved these changes
Oct 28, 2025
There was a problem hiding this comment.
I don’t feel strongly about data- attribute vs data-attribute, so feel free to not commit the suggestions. But to me at least, “data-attribute” seemed odd (I don’t recall having seen it in existing content) — at least, ambiguous and potentially confusing to readers. So data- attribute seems less ambiguous and less potentially confusing.
Co-authored-by: sideshowbarker <mike@w3.org>
Co-authored-by: sideshowbarker <mike@w3.org>
|
Thanks @sideshowbarker . I think you're right. Accepted your changes, though in a couple of places made minor changes so that it wouldn't break the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows #41695 with even more tweaks to the setHTML methods. Specifically it makes clear that data-attributes are not removed by in all cases (though they are by the default sanitizer). It adds embed to the list of elements that can be removed.
In addition, this tidies the examples a bit, which were broken by a recently added script end tag.