-
Notifications
You must be signed in to change notification settings - Fork 23.1k
New CSS reference: Keyframe selectors #42573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview URLs (11 pages)
Flaws (33)Note! 8 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
(comment last updated: 2026-01-06 15:00:09) |
chrisdavidmills
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@estelle adding a keyframe selector page is a nice idea. I've got some comments for you to consider.
estelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am working on a guide on range insets. I'll link to that guide from this page in that PR, once this page is merged.
|
Hi Estelle - I checked out this PR and I can see that the macro does not resolve as expected to I was considering reaching out to the engineering team, but I realized that using the macro would add code formatting to "keyframe", which we probably don't want in "keyframe selector" contexts, since "keyframe" is not a keyword. |
chrisdavidmills
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@estelle A few more comments for you, but nice work — this is very nearly there. The new split-up examples are much better and make a lot more sense.
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org> Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Thanks. Makes sense. all the named selector types, like id, class, universal, etc., don't support macros either. Example: |
chrisdavidmills
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @estelle. I've got one more minor nit for you to address, but I don't think I need to look at this again. Approving.
files/en-us/web/css/reference/selectors/keyframe_selectors/index.md
Outdated
Show resolved
Hide resolved
dipikabh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…ex.md Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
we reference keyframe selectors a bunch of times, but there was no reference page for them.