Skip to content

Conversation

@estelle
Copy link
Member

@estelle estelle commented Dec 30, 2025

we reference keyframe selectors a bunch of times, but there was no reference page for them.

@estelle estelle requested review from a team as code owners December 30, 2025 15:53
@estelle estelle requested review from chrisdavidmills and sideshowbarker and removed request for a team December 30, 2025 15:53
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Dec 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025

Preview URLs (11 pages)
Flaws (33)

Note! 8 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/Reference/At-rules/@keyframes
Title: @keyframes
Flaw count: 4

  • broken_links:
    • Link /en-US/docs/Web/CSS/qualified-rule-list doesn't resolve
    • Link /en-US/docs/Web/CSS/custom-ident is a redirect
    • Link /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#single_bar is a redirect
    • Link /en-US/docs/Web/CSS/string is a redirect

URL: /en-US/docs/Web/CSS/Reference/Properties/animation-range
Title: animation-range
Flaw count: 27

  • broken_links:
    • Link /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#brackets is a redirect
    • Link /en-US/docs/Web/CSS/animation-range-start is a redirect
    • Link /en-US/docs/Web/CSS/animation-range-end is a redirect
    • Link /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#question_mark is a redirect
    • Link /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#brackets is a redirect
    • and 18 more flaws omitted
  • macros:
    • Macro cssinfo produces link /en-US/docs/Web/CSS/CSS_cascade/Value_processing which is a redirect
    • Macro cssinfo produces link /en-US/docs/Web/CSS/CSS_cascade/Inheritance which is a redirect
    • Macro cssinfo produces link /en-US/docs/Web/CSS/CSS_cascade/Value_processing which is a redirect
    • Macro cssinfo produces link /en-US/docs/Web/CSS/CSS_animated_properties which is a redirect

URL: /en-US/docs/Web/CSS/Reference/Selectors/Keyframe_selectors
Title: Keyframe selectors
Flaw count: 2

  • broken_links:
    • Link /en-US/docs/Web/CSS/CSS_Animations/Using_CSS_animations is a redirect
    • Link /en-US/docs/Web/CSS/CSS_Animations is a redirect

(comment last updated: 2026-01-06 15:00:09)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle adding a keyframe selector page is a nice idea. I've got some comments for you to consider.

Copy link
Member Author

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am working on a guide on range insets. I'll link to that guide from this page in that PR, once this page is merged.

@dipikabh
Copy link
Contributor

dipikabh commented Jan 6, 2026

Hi Estelle - I checked out this PR and I can see that the macro does not resolve as expected to /en-US/docs/Web/CSS/Reference/Selectors/Keyframe. I tried a few other versions of slug and filename but none seem to be working with the macro.

I was considering reaching out to the engineering team, but I realized that using the macro would add code formatting to "keyframe", which we probably don't want in "keyframe selector" contexts, since "keyframe" is not a keyword.

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle A few more comments for you, but nice work — this is very nearly there. The new split-up examples are much better and make a lot more sense.

@sideshowbarker sideshowbarker removed their request for review January 6, 2026 09:14
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
estelle and others added 3 commits January 6, 2026 12:09
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle
Copy link
Member Author

estelle commented Jan 6, 2026

Hi Estelle - I checked out this PR and I can see that the macro does not resolve as expected to /en-US/docs/Web/CSS/Reference/Selectors/Keyframe. I tried a few other versions of slug and filename but none seem to be working with the macro.

I was considering reaching out to the engineering team, but I realized that using the macro would add code formatting to "keyframe", which we probably don't want in "keyframe selector" contexts, since "keyframe" is not a keyword.

Thanks. Makes sense. all the named selector types, like id, class, universal, etc., don't support macros either. Example: [Type selectors](/en-US/docs/Web/CSS/Reference/Selectors/Type_selectors).
That said, i'll rename the file path Keyframe_selector

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @estelle. I've got one more minor nit for you to address, but I don't think I need to look at this again. Approving.

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

…ex.md

Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@estelle estelle merged commit a397ab7 into main Jan 7, 2026
12 checks passed
@estelle estelle deleted the keyframe-selector branch January 7, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants