Fix incorrect Chinese calendar example in Temporal.PlainDate.from docs #42660
+17
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Chinese calendar example incorrectly stated that year 2021 in the Chinese calendar corresponds to 616 BC in the ISO calendar. According to the TC39 Intl era and monthCode proposal, the Chinese calendar's epoch year is now ISO year 0, so year 2021 aligns with ISO year 2021. This commit: - Updates the Chinese calendar example comment to reflect the correct epoch year alignment - Corrects the expected output from "-000616-08-12[u-ca=chinese]" to "2021-08-08[u-ca=chinese]" - Adds a new Hebrew calendar example to demonstrate a calendar with a significantly different epoch year (5781 Hebrew = 2021 ISO) Fixes mdn#42565
github-actions
bot
added
Content:JS
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the Chinese calendar example in
Temporal.PlainDate.from()documentation:"2021-08-08[u-ca=chinese]"instead of"-000616-08-12[u-ca=chinese]"Per TC39 proposal, the Chinese calendar's epoch is ISO year 0, not -616 BCE.
Motivation
Additional details
Related issues and pull requests
Fixes #42565