-
Notifications
You must be signed in to change notification settings - Fork 14
Package fonts with niceplots #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@eirikurj we need your review here because niceplots only accepts reviews from maintainers, which is now only me and you. Maybe we should change the rules so that non-maintainer's reviews are acceptable too. |
I should have fixed it, lab members have write permission now. Hannah's review is "green" now, but the merge still has to be done by a maintainer. |
I'm still getting this |

Purpose
The most common complaint we get about niceplots is that our styles try to use fonts that aren't installed on people's computers by default. This leads to lots of warnings about missing fonts if the user doesn't install the fonts themselves, which can be scary for people new to python.
This PR adds the Prompt and computer modern fonts to niceplots as package data, the fonts are then added to the matplotlib font manager when niceplots is imported. This simultaneously fixes the issue we're having with our GitHub actions and means users no longer have to install the fonts themselves!
Both fonts are distributed with the SIL open font license so I don't think it's an issue to host them here in the repo.
Expected time until merged
Type of change
Testing
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable