Skip to content

Conversation

@kanekosh
Copy link
Contributor

@kanekosh kanekosh commented Jul 28, 2025

Purpose

Minor version bump as we switched to a new IPOPT wrapper using cyipopt in #425 and we'll clean up the ParOpt support soon. Let me know if you think a patch version bump would be more appropriate.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@kanekosh kanekosh requested a review from a team as a code owner July 28, 2025 15:39
@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.26%. Comparing base (22bdeb8) to head (8ee47c8).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   86.26%   86.26%           
=======================================
  Files          24       24           
  Lines        3399     3399           
=======================================
  Hits         2932     2932           
  Misses        467      467           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kanekosh kanekosh marked this pull request as draft July 28, 2025 16:20
@kanekosh
Copy link
Contributor Author

Actually this should wait until the ParOpt PR (#414 or a new one) is merged

@eirikurj
Copy link
Contributor

Its probably fine to make a minor bump (especially if waiting for ParOpt). However, it looks like we forgot to make a release for v2.13.2 (see PR here and diff here), which does include the cyipopt change. Anything after that is a very minor doc string change (see diff here).
Not sure if we want to make a release for v2.13.2 retroactively or just go straight to v2.14.0.

@ewu63
Copy link
Collaborator

ewu63 commented Jul 28, 2025

Hmm interesting, I think the cyipopt change definitely warrants a minor version bump. Do we need to wait for ParOpt though? I feel we can just release this now.

I've also opened #446 to discuss better versioning process.

@marcomangano marcomangano marked this pull request as ready for review July 31, 2025 19:35
@marcomangano marcomangano merged commit bf7d311 into main Jul 31, 2025
18 checks passed
@marcomangano marcomangano deleted the version-bump branch July 31, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants