fix: add missing acorn dependency to recma-jsx #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes mdx-js#2 by adding acorn as both devDependency and peerDependency to ensure proper JSX parsing functionality.
github-actions
bot
added
👋 phase/new
Update basic fixture expected AST to reflect changes in AST structure when acorn is properly declared as a dependency.
remcohaszing
requested changes
Jul 19, 2025
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
remcohaszing
approved these changes
Jul 19, 2025
ChristianMurphy
approved these changes
Jul 19, 2025
wooorm
approved these changes
Jul 28, 2025
This comment has been minimized.
This comment has been minimized.
Member
|
Thanks, released! https://github.com/mdx-js/recma/releases/tag/recma-jsx%401.0.1 |
wooorm
added a commit
to mdx-js/mdx
that referenced
this pull request
Aug 29, 2025
Yarn results in trouble for peer dependencies. This solves that. Related-to: mdx-js/recma#3. Closes GH-2634.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2 by adding acorn as both devDependency and peerDependency to ensure proper JSX parsing functionality.
Initial checklist
Description of changes
This PR adds the missing
acorndependency to therecma-jsxpackage:acornas a devDependency (^8.0.0)acornas a peerDependency (^6.0.0 || ^7.0.0 || ^8.0.0)This ensures proper JSX parsing functionality and resolves the dependency issue reported in #2.