Open
Conversation
Member
Author
|
I remembered that we had actual integration tests, so I ran them! Found one bug, but after fixing it, the tests pass like they do in the sqlite branch. It would be nice to have you run your "load testing" scripts for this version also if you still have them handy. |
Member
Author
|
Fixed all sqlite integration tests and made the lock global to the whole process, not just the db object. load testing would still be nice, but i think this is starting to be merge ready.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should eliminate SQLite db access concurrency within single process.
Also contains small fixes to make lint happy.
This is completely untested code. Can you please test this before making a release and pushing this to production? :) :P