Adds support for the use of external dictionaries for segmenters backed by lindera#326
Adds support for the use of external dictionaries for segmenters backed by lindera#326PedroTurik wants to merge 5 commits intomeilisearch:mainfrom
Conversation
|
Thanks for working on this! If writing documentation is currently holding this back, I'd help out with that. |
|
Hey @PedroTurik, |
|
Hey @slatian Yes, you are correct. Where do you think I should document the process to use this feature? Also, thanks @ManyTheFish. I will fix the CI error and open the PR for review as you said |
As a user of the crate I'd expect the documentation for this with the rest of the documentation on docs.rs -> Document it in a module. Depending on the length, either a But @ManyTheFish will probably have an opinion on that too. |
|
Hi @PedroTurik, If you want to use Meilisearch, I suggest activating the feature at runtime because without it, it will not be possible to integrate it easily. |
Pull Request
Related issue
Fixes #322
What does this PR do?
this PR is not finished. Since we cant control which dict the user will use, we cant be sure about the segmentation process, so activating the features will disable segmentation tests for now. Another thing worth mentioning is that for lindera to use an external dict, you need generate it through the lindera CLI. The process isnt exactly obvious and needs to be documented. Its described here