#315 - Concept Sets domain incorrectly unretires referenced concepts#316
Merged
mseaton merged 2 commits intomekomsolutions:mainfrom Mar 4, 2026
Merged
#315 - Concept Sets domain incorrectly unretires referenced concepts#316mseaton merged 2 commits intomekomsolutions:mainfrom
mseaton merged 2 commits intomekomsolutions:mainfrom
Conversation
mseaton
commented
Mar 3, 2026
| // We need to process all set members, whether the underlying concept is retired or not | ||
| return true; | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
These are the primary fixes that are needed
| if (saved > 250) { // TODO make this configurable | ||
| Context.flushSession(); | ||
| Context.clearSession(); | ||
| if (saved % 250 == 0) { // TODO make this configurable |
Collaborator
Author
There was a problem hiding this comment.
This is unrelated, but I found during testing. Changing this from > 250 to % 250, and adding additional logging so that more progress can be assessed during long-running loads. For example, I was loading in concepts and conceptssets csvs that each had about 10,000 rows and takes around 8-10 minutes.
mogoodrich
approved these changes
Mar 3, 2026
Contributor
mogoodrich
left a comment
mogoodrich
left a comment
There was a problem hiding this comment.
LGTM, thanks @mseaton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.