Skip to content

Removed duplicated limit param #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dapregi wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Removed duplicated limit param #1

dapregi wants to merge 1 commit into from

Conversation

@dapregi
Copy link

@dapregi dapregi commented Feb 9, 2024

Duplicated "limit" param causes CellBase to return an HTTP ERROR 500. And because "limit" is always populated (its value is 1000 by default), every time CellBaseParams is used in a query, it fails.

Example code to replicate the error:

library(cellbaseR)
cb <- CellBaseR(host="https://ws.zettagenomics.com/cellbase/webservices/rest/", version="v5", species="hsapiens")
cbparam <- CellBaseParam(assembly = 'GRCh38')
res <- getVariant(object=cb, ids=c('1:64844827:G:A'), resource="annotation", param = cbparam)
str(res, 1)

Error returned:

Error: lexical error: invalid char in json text.
                                       <html> <head> <meta http-equiv=
                     (right here) ------^

This PR removes duplicated "limit" param from every get function (except getClinical, which was working fine).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dapregi