Avoid polluting global namespace with nodeFileReady function#124
Open
lukaszfiszer wants to merge 1 commit intomeltingice:masterfrom
lukaszfiszer:nodeFileReady-global-pollution
Open
Avoid polluting global namespace with nodeFileReady function#124lukaszfiszer wants to merge 1 commit intomeltingice:masterfrom lukaszfiszer:nodeFileReady-global-pollution
nodeFileReady function#124lukaszfiszer wants to merge 1 commit intomeltingice:masterfrom
lukaszfiszer:nodeFileReady-global-pollution
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current version of Caman the
nodeFileReadyfunction is polluting the global namespace.I'm not very confident with CoffeeScript so this commit may not be the best/valid way of correcting this bug. Actually, I'm quite confused with
->and=>mentioned in the commit above the line 110. Please double-check before merging it. Thanks :)