Skip to content

refactor: improve error message in schema validation exception #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christiangoerdes merged 2 commits into from
Apr 10, 2026
Merged

refactor: improve error message in schema validation exception #2902

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6dba27
refactor: improve error message in schema validation exception
predic8 Apr 7, 2026
ff393a1
Use `String.formatted` for improved readability in exception message
christiangoerdes Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 25 additions & 18 deletions ...ain/java/com/predic8/membrane/core/interceptor/schemavalidation/ValidatorInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,25 +14,32 @@

package com.predic8.membrane.core.interceptor.schemavalidation;

import com.predic8.membrane.annot.*;
import com.predic8.membrane.core.exchange.*;
import com.predic8.membrane.core.http.*;
import com.predic8.membrane.core.interceptor.*;
import com.predic8.membrane.core.interceptor.schemavalidation.json.*;
import com.predic8.membrane.core.proxies.*;
import com.predic8.membrane.core.resolver.*;
import com.predic8.membrane.core.util.*;
import org.jetbrains.annotations.*;
import org.slf4j.*;
import org.springframework.beans.*;
import org.springframework.context.*;

import static com.predic8.membrane.core.exceptions.ProblemDetails.*;
import static com.predic8.membrane.core.interceptor.Interceptor.Flow.*;
import static com.predic8.membrane.core.interceptor.Outcome.*;
import com.predic8.membrane.annot.MCAttribute;
import com.predic8.membrane.annot.MCChildElement;
import com.predic8.membrane.annot.MCElement;
import com.predic8.membrane.core.exchange.Exchange;
import com.predic8.membrane.core.http.ReadingBodyException;
import com.predic8.membrane.core.interceptor.AbstractInterceptor;
import com.predic8.membrane.core.interceptor.Outcome;
import com.predic8.membrane.core.interceptor.schemavalidation.json.JSONYAMLSchemaValidator;
import com.predic8.membrane.core.interceptor.schemavalidation.json.SchemaMappings;
import com.predic8.membrane.core.proxies.SOAPProxy;
import com.predic8.membrane.core.resolver.ResolverMap;
import com.predic8.membrane.core.util.ConfigurationException;
import org.jetbrains.annotations.Nullable;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.BeansException;
import org.springframework.context.ApplicationContext;
import org.springframework.context.ApplicationContextAware;

import static com.predic8.membrane.core.exceptions.ProblemDetails.internal;
import static com.predic8.membrane.core.interceptor.Interceptor.Flow.REQUEST;
import static com.predic8.membrane.core.interceptor.Interceptor.Flow.RESPONSE;
import static com.predic8.membrane.core.interceptor.Outcome.ABORT;
import static com.predic8.membrane.core.interceptor.Outcome.CONTINUE;
import static com.predic8.membrane.core.resolver.ResolverMap.combine;
import static com.predic8.membrane.core.util.text.TextUtil.*;
import static com.predic8.membrane.core.util.text.TextUtil.linkURL;

/**
* Basically switches over {@link WSDLValidator}, {@link XMLSchemaValidator},
Expand Down Expand Up @@ -86,7 +93,7 @@ public void init() {
validator = getMessageValidator();
validator.init();
} catch (Exception e) {
throw new ConfigurationException("Cannot create message validator.", e);
throw new ConfigurationException("Cannot create message validator: %s".formatted(e.getMessage()), e);
}
name = validator.getName();
if (skipFaults && wsdl == null)
Expand Down
Loading