Keyboard Shortcuts for mBufferMinButton (ctrl-J), mRecvSyncButton (ctrl-shift-J)

[Copilot]

Keyboard shortcuts for RecvSyncToggle and ResetAllJitterBuffers were inverted - user testing on macOS revealed Cmd-J triggered buffer reset instead of receive sync, and vice versa.

Changes

Swapped keyboard bindings in getCommandInfo():

// ResetAllJitterBuffers: Ctrl-Shift-J → Ctrl-J
info.addDefaultKeypress('j', ModifierKeys::commandModifier);

// RecvSyncToggle: Ctrl-J → Ctrl-Shift-J  
info.addDefaultKeypress('j', ModifierKeys::commandModifier | ModifierKeys::shiftModifier);

Result:

• Ctrl-J: Reset jitter buffers to minimum
• Ctrl-Shift-J: Synchronize receive latency across peers

Original prompt

Add Keyboard Shortcuts for Receive Sync and Buffer Min Buttons

Objective

Add keyboard shortcuts for two important buffer management buttons in the SonoBus application.

Required Changes

1. New Keyboard Shortcuts to Add:

• mRecvSyncButton: Control-J (Command-J on Mac)

  • Function: Toggle Receive Sync - synchronizes receive latency for all users
  • Button location: Main peer view area

• mbufferMinButton: Control-Shift-J (Command-Shift-J on Mac)

  • Function: Reset Buffer Min - resets jitter buffer to minimum for all connected users
  • Button location: Main peer view area

2. Implementation Requirements:

File to modify: Source/SonobusPluginEditor.cpp and Source/SonobusPluginEditor.h

The implementation should follow the existing pattern used for other keyboard shortcuts in the codebase (like Control-R for Record Toggle).

In the header file (SonobusPluginEditor.h):

• Command IDs should be added to the existing command ID enumeration/definition area

In the implementation file (SonobusPluginEditor.cpp):

a. getAllCommands method: Add the new command IDs to the list of available commands

b. getCommandInfo method: Add cases for both new commands with:

• Command name and description
• Keyboard shortcut assignment using result.addDefaultKeypress()
• For mRecvSyncButton: KeyPress('j', ModifierKeys::commandModifier, 0)
• For mbufferMinButton: KeyPress('j', ModifierKeys::commandModifier | ModifierKeys::shiftModifier, 0)

c. perform method: Add cases to handle the command execution:

• For mRecvSyncButton: Trigger the button click with mRecvSyncButton->triggerClick()
• For mbufferMinButton: Trigger the button click (needs reference to the button in PeersContainerView)

3. Context from Existing Code:

• The buttons are defined in Source/PeersContainerView.cpp:

  • mRecvSyncButton - described in OSC docs as "Synchronizes receive latency for all users"
  • mbufferMinButton - has tooltip "Resets jitter buffer to the minimum"

• Current keyboard shortcuts pattern (from User Guide):

  Record Toggle     = Control-R
  Mute All Input    = M or Control-M
  Play/Pause File   = Spacebar or Control-P
  

• The ModifierKeys::commandModifier automatically maps to:

  • Control key on Windows/Linux
  • Command key on macOS

4. Testing Considerations:

• Ensure shortcuts work when the main window has focus
• Verify no conflicts with existing shortcuts
• Test on both macOS (Command key) and Windows/Linux (Control key)

Verification:

The implementation should allow users to press:

• Ctrl-J (or Cmd-J on Mac) to synchronize receive buffers
• Ctrl-Shift-J (or Cmd-Shift-J on Mac) to reset buffer to minimum

Both shortcuts should have the same effect as clicking the respective buttons with the mouse.

This pull request was created from Copilot chat.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.