MEN-3730 OpenSSL via spacemonkey.#578
Closed
merlin-northern wants to merge 1 commit intomendersoftware:masterfrom
Closed
MEN-3730 OpenSSL via spacemonkey.#578merlin-northern wants to merge 1 commit intomendersoftware:masterfrom
merlin-northern wants to merge 1 commit intomendersoftware:masterfrom
Conversation
|
Hello 😸 I created a pipeline for you here: Pipeline-170086198 Build Configuration Matrix
|
merlin-northern
force-pushed
the
men_3730_openssl_support_via_spacemonkey
branch
from
f725b4b to
414365b
Compare
|
Hello 😸 I created a pipeline for you here: Pipeline-170089559 Build Configuration Matrix
|
ghost
suggested changes
Jul 24, 2020
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
This is the entire patch? Impressive! So once we knew what to do, it wasn't so difficult after all. :-)
Changing to OpenSSL is an important change, so this needs a good changelog. I would even consider a dedicated one, like changelog: Switch to OpenSSL for all server communication.
client/client.go
Outdated
| } | ||
|
|
||
| func dialOpenSSL(ctx context.Context, network, addr string) (net.Conn, error) { | ||
| //contextSSL := ctx.Value("ssl").(*openssl.Ctx) |
Contributor
Author
There was a problem hiding this comment.
sure. it will be clean in the final PR.
|
Hello 😸 I created a pipeline for you here: Pipeline-171139117 Build Configuration Matrix
|
|
Hello 😸 I created a pipeline for you here: Pipeline-171208767 Build Configuration Matrix
|
merlin-northern
force-pushed
the
men_3730_openssl_support_via_spacemonkey
branch
from
03553eb to
b5c62f1
Compare
|
Hello 😸 I created a pipeline for you here: Pipeline-172076754 Build Configuration Matrix
|
merlin-northern
force-pushed
the
men_3730_openssl_support_via_spacemonkey
branch
from
b5c62f1 to
c6c03e0
Compare
|
Hello 😸 I created a pipeline for you here: Pipeline-172082650 Build Configuration Matrix
|
merlin-northern
force-pushed
the
men_3730_openssl_support_via_spacemonkey
branch
from
c6c03e0 to
fb777b8
Compare
|
Hello 😸 I created a pipeline for you here: Pipeline-172090614 Build Configuration Matrix
|
merlin-northern
force-pushed
the
men_3730_openssl_support_via_spacemonkey
branch
from
fb777b8 to
5b6f13f
Compare
|
Hello 😸 I created a pipeline for you here: Pipeline-172100267 Build Configuration Matrix
|
merlin-northern
force-pushed
the
men_3730_openssl_support_via_spacemonkey
branch
from
5b6f13f to
95858a9
Compare
|
Hello 😸 I created a pipeline for you here: Pipeline-172108253 Build Configuration Matrix
|
merlin-northern
force-pushed
the
men_3730_openssl_support_via_spacemonkey
branch
from
95858a9 to
73841b5
Compare
|
Hello 😸 I created a pipeline for you here: Pipeline-172111747 Build Configuration Matrix
|
merlin-northern
force-pushed
the
men_3730_openssl_support_via_spacemonkey
branch
from
73841b5 to
9d3e281
Compare
|
Hello 😸 I created a pipeline for you here: Pipeline-172114176 Build Configuration Matrix
|
merlin-northern
force-pushed
the
men_3730_openssl_support_via_spacemonkey
branch
from
9d3e281 to
634df70
Compare
|
Hello 😸 I created a pipeline for you here: Pipeline-172169169 Build Configuration Matrix
|
merlin-northern
force-pushed
the
men_3730_openssl_support_via_spacemonkey
branch
from
634df70 to
48cd64e
Compare
|
Hello 😸 I created a pipeline for you here: Pipeline-172199158 Build Configuration Matrix
|
merlin-northern
force-pushed
the
men_3730_openssl_support_via_spacemonkey
branch
from
48cd64e to
0426f0d
Compare
|
Hello 😸 I created a pipeline for you here: Pipeline-172229843 Build Configuration Matrix
|
merlin-northern
force-pushed
the
men_3730_openssl_support_via_spacemonkey
branch
from
0426f0d to
77e074b
Compare
|
Hello 😸 I created a pipeline for you here: Pipeline-172232885 Build Configuration Matrix
|
merlin-northern
force-pushed
the
men_3730_openssl_support_via_spacemonkey
branch
from
77e074b to
c398f9c
Compare
|
Hello 😸 I created a pipeline for you here: Pipeline-172237248 Build Configuration Matrix
|
merlin-northern
force-pushed
the
men_3730_openssl_support_via_spacemonkey
branch
from
c398f9c to
c2a29d8
Compare
|
Hello 😸 I created a pipeline for you here: Pipeline-172240401 Build Configuration Matrix
|
merlin-northern
force-pushed
the
men_3730_openssl_support_via_spacemonkey
branch
from
c2a29d8 to
7e22642
Compare
|
Hello 😸 I created a pipeline for you here: Pipeline-172243048 Build Configuration Matrix
|
merlin-northern
force-pushed
the
men_3730_openssl_support_via_spacemonkey
branch
from
7e22642 to
74a2fd4
Compare
|
Hello 😸 I created a pipeline for you here: Pipeline-172243769 Build Configuration Matrix
|
ChangeLog:none Signed-off-by: Peter Grzybowski <peter@northern.tech>
merlin-northern
force-pushed
the
men_3730_openssl_support_via_spacemonkey
branch
from
74a2fd4 to
421228c
Compare
|
Hello 😸 I created a pipeline for you here: Pipeline-172244395 Build Configuration Matrix
|
Contributor
Author
|
I had to move to #579 will tidy up |
alfrunes
reviewed
Jul 31, 2020
| } | ||
| if v != openssl.Ok { | ||
| if v == openssl.CertHasExpired || v == openssl.DepthZeroSelfSignedCert { | ||
| return nil, errors.New(fmt.Sprintf("certificate has expired, openssl says: %d", v)) |
Contributor
There was a problem hiding this comment.
errors.Errorf or fmt.Errorf?
Contributor
Author
There was a problem hiding this comment.
sure Alf, thanks. (it will go into the final PR)
Contributor
Author
will do! |
Contributor
Author
|
superseded by #581 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChangeLog:none
Signed-off-by: Peter Grzybowski peter@northern.tech