Skip to content

Add tabs delete method including event namespace to protect non-jQuery Tools events. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bradgreens wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add tabs delete method including event namespace to protect non-jQuery Tools events. #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
083f1c0
Add delete method including event namespace to protect non-jQuery Too…
Jun 19, 2013
5ec4d8d
Update destroy method to be a little more concise
Jun 19, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions tools.tabs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
* Revision: ${revision}
*/
(function($) {


var namespace = '.tools-tabs';

// static constructs
$.tools = $.tools || {};

Expand Down Expand Up @@ -103,7 +105,7 @@

// bind all callbacks from configuration
$.each(conf, function(name, fn) {
if ($.isFunction(fn)) { $self.bind(name, fn); }
if ($.isFunction(fn)) { $self.bind(name + namespace, fn); }
});


Expand Down Expand Up @@ -194,7 +196,7 @@
},

bind: function(name, fn) {
$self.bind(name, fn);
$self.bind(name + namespace, fn);
return self;
},

Expand All @@ -209,14 +211,23 @@
unbind: function(name) {
$self.unbind(name);
return self;
}

},

destroy: function() {
this.unbind(namespace);
this.getTabs()
.unbind(namespace)
.parent().removeData('tabs');
this.getPanes()
.find("a[href^=#]").unbind(namespace)
.end().show();
}
});


// setup click actions for each tab
tabs.each(function(i) {
$(this).bind(conf.event, function(e) {
$(this).bind(conf.event + namespace, function(e) {
self.click(i, e);
return false;
});
Expand All @@ -232,7 +243,7 @@
}

// cross tab anchor link
panes.find("a[href^=#]").click(function(e) {
panes.find("a[href^=#]").bind('click' + namespace, function(e) {
self.click($(this).attr("href"), e);
});
}
Expand Down Expand Up @@ -282,4 +293,3 @@

}) (jQuery);