support deps.edn, clj-kondo, other minor fixes#5
Open
imrekoszo wants to merge 9 commits intomeredydd:masterfrom
Open
support deps.edn, clj-kondo, other minor fixes#5imrekoszo wants to merge 9 commits intomeredydd:masterfrom
imrekoszo wants to merge 9 commits intomeredydd:masterfrom
Conversation
Co-authored-by: Krisztian Szabo <thenonameguy24@gmail.com>
Co-authored-by: Krisztian Szabo <thenonameguy24@gmail.com>
Co-authored-by: Krisztian Szabo <thenonameguy24@gmail.com>
Owner
|
Thank you! Chunky PR and I'm travelling this weekend, so won't get to it in the next couple of days, but I'd like to get this done relatively promptly. |
Contributor
Author
|
Take your time, no rush. I do recommend going commit by commit. I reorganized the changes into more semantic commits. |
Contributor
Author
|
I also have another change lined up to resolve some linting warnings when these get released for clj-kondo https://github.com/clj-kondo/clj-kondo/blob/61f26cf0bc06b957a60cf4f9efdbd6d4c7dc3909/CHANGELOG.md#unreleased |
Contributor
Author
|
Note: the clj-kondo hook doesn't leverage any core.match support that clj-kondo might have. If there is adequate support there, then this could be simplified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #3 (comment), this PR upstreams the meaningful part of changes originally developed for the Ekata fork of this library.