-
Notifications
You must be signed in to change notification settings - Fork 6
Firefox support #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Since Firefox builds are not yet in releases, update instructions to clone and build the extension from source using npm run build:firefox
Summary of ChangesHello @jorgeasaurus, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the extension's reach by adding full support for the Firefox browser. It involves creating a specialized build process for Firefox, developing a robust cross-browser API compatibility layer to handle platform differences, and updating the user interface with custom icons. Additionally, comprehensive documentation has been added to guide users and developers through the Firefox-specific setup and usage. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Addressing #2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces Firefox support, which is a great addition. The changes include a new build pipeline for Firefox, a compatibility layer for browser APIs, and updates to documentation.
My review has identified a critical architectural issue: there are four different and inconsistent strategies for handling cross-browser API compatibility. This will make the code difficult to maintain and debug. I strongly recommend standardizing on a single approach. The explicit wrapper module src/common/browserApi.js seems like the most robust and maintainable option.
Additionally, I've found a couple of unused files that appear to be remnants of alternative implementations. Removing this dead code will improve clarity. I've also suggested some refactoring to reduce code duplication and improve efficiency in the new helper modules. Finally, there are a few minor inconsistencies in the new FIREFOX_README.md that should be addressed.
Overall, the PR is in good shape, but addressing these architectural and maintainability points will significantly improve the quality of the codebase.
|
Addressing Gemini Code Comments and reopening. |
…; unify browser API handling, streamline storage and tab functions, and enhance DevTools integration.
|
🎁 EMERGENCY MERGE: Santa needs this code! 🎅 Please, oh please! Grant this little PR its Christmas miracle! 🙏 Let's get this done before Santa makes his rounds! You're the best! |
Pull Request Summary
scripts/build-firefox.js,public/manifest.firefox.json, and devtools bootstrap scripts.src/common/browserApi.js) and updated consumers (for example,src/common/client.js) so promise-based messaging and storage work in Firefox.FIREFOX_README.md).