fix: expose radio.rxgain CLI to Companion firmware#2259
Open
jirogit wants to merge 1 commit intomeshcore-dev:devfrom
Open
fix: expose radio.rxgain CLI to Companion firmware#2259jirogit wants to merge 1 commit intomeshcore-dev:devfrom
jirogit wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
Add get/set radio.rxgain commands to Companion's CLI rescue mode. Previously only available on Repeater and Room Server via CommonCLI. Noted as follow-up in PR meshcore-dev#1653 by jbrazio.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
get/set radio.rxgaincommands were only available on Repeater andRoom Server firmware via CommonCLI. Companion firmware returned
"unknown config" for these commands.
This was noted as a follow-up in PR #1653 by jbrazio:
Changes
get radio.rxgainto Companion CLI rescue modeset radio.rxgain on/offto Companion CLI rescue modesavePrefs()and applied immediatelyvia
radio_driver.setRxBoostedGainMode()Testing
Tested on WisMesh Tag (nRF52840 + SX1262):
get radio.rxgain→ returns current stateset radio.rxgain on/set radio.rxgain off→ confirmed working