dependencies/ui.py: Improve Vulkan detection on Windows #15263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcbaker
requested changes
Nov 18, 2025
Member
dcbaker
left a comment
dcbaker
left a comment
There was a problem hiding this comment.
A couple of small nits here, but otherwise this looks good to me.
fanc999-1
force-pushed
the
vulkan-windows
branch
from
4bac250 to
a68c46a
Compare
dcbaker
requested changes
Nov 21, 2025
Member
dcbaker
left a comment
dcbaker
left a comment
There was a problem hiding this comment.
Thanks! this is looking really good, I'm still hoping to get this in for 1.10, and I have one small thing I think can be improved here.
mesonbuild/dependencies/ui.py
Outdated
| unsupported_target_arch = True | ||
|
|
||
| if unsupported_target_arch: | ||
| raise DependencyException('Target architecture \'%s\' is not supported for this Vulkan SDK.' % host_cpu) |
Member
There was a problem hiding this comment.
Suggested change
| raise DependencyException('Target architecture \'%s\' is not supported for this Vulkan SDK.' % host_cpu) | |
| raise DependencyException(f'Target architecture \'{host_cpu}\' is not supported for this Vulkan SDK.') |
We prefer f-strings for simple substitutions or str.format() for complex ones.
Ah, you thought of more error cases than I did, I only noticed the build_cpu being unsupported I think it would be simpler to set lib_dir to some initial sentinel value like lib_dir = '' and then check for that at the end for the error condition.
There now exists a Windows Vulkan SDK for ARM64, and the latest Vulkan SDKs for x64 Windows also provides ARM64 libraries and binaries for cross-builds (and vice-versa). So, now we have the following in the Vulkan SDKs: * Bin-ARM64 and Lib-ARM64 in x64 Windows SDKs that contains ARM64 Vulkan binaries and libraries. * Bin-X64 and Lib-X64 in ARM64 Windows SDKs that contains x64 Vulkan binaries and libraries * SDKs after 1.4.x (or so) no longer ships 32-bit Windows binaries and libraries. This updates the Vulkan detection logic to account for these differences so that the correct library is picked up upon linking on Windows, especially when cross-compiling ARM64 binaries on x64 Windows, and vice versa, while maintaining compatibility with native and 32-bit builds.
fanc999-1
force-pushed
the
vulkan-windows
branch
from
a68c46a to
e498ce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There now exists a Windows Vulkan SDK for ARM64, and the latest Vulkan SDKs for x64 Windows also provides ARM64 libraries and binaries for cross-builds (and vice-versa).
So, now we have the following in the Vulkan SDKs:
This updates the Vulkan detection logic to account for these differences so that the correct library is picked up upon linking on Windows, especially when cross-compiling ARM64 binaries on x64 Windows, and vice versa, while maintaining compatibility with native and 32-bit builds.
With blessings, thank you!