Add and use a an alias for Program types #15267
Closed
+67
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are useful for the many cases of creating lists of commands that are mixtures of strings and programs
This doesn't cover every possible use, but it does cover a lot of the obvious places where the exact alias is in use. There are also a number of places that *should* use this alias that don't.
There's some typing issues here that are shadowed by not using the shared helpers. As soon as we switch over to those we run into clear type problems. Let's fix that.
Collaborator
|
@xclaesse had something very similar, but iirc a bit more comprehensive, as part of his LocalProgram attempt. I think it's worth disentangling it from language changes and going his way instead. I will take a look for 1.11 too. |
Member
Author
|
Either way I guess. I didn't really look at that PR, so I'm not sure what all went on with it. |
Collaborator
|
See #15277 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to the work I did using a
TypeAliasfor build targets, but for programs.There are more places we should be using this, especially in
build.py, but for the moment this is a good cleanup by itself, and will help us catch future regressions.I've marked the for 1.11, I don't expect (or want) it to land for 1.10