enable DDA AR, AG, RS, A2A by default, and check NRANKS to avoid DDA assert error #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
…assert error (meta-pytorch#131) Summary: In this diff: - we enable all DDA collectives (AllReduce, AllGather, ReduceScatter, AllToAll) by default - To avoid the assert error inside DDA (DDA only supports NRANKS=8), we add the check in AlgoInit.h to disable DDA when comm.nRanks != 8. - Fix failed test: rccl_allreduce_perf_bench --> error "invalid device context" (show in V1) - Root-cause: "zgpu_benchmark" --> D90052113 - In zgpu_benchmark, it sets rccl-tests args "-g 8" which means 8 GPUs per thread, IPC (inter-process communication) does not compile with this scheme - So, we set "-g 1" in zgpu_benchmark to fix it Mast jobs: https://fburl.com/network/o2c0v5ov ToDo: make DDA support nRanks < 8 case? Reviewed By: dmwu Differential Revision: D89249175
liukeOoO
force-pushed
the
export-D89249175
branch
from
213a6d7 to
b28414f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In this diff:
Mast jobs: https://fburl.com/network/o2c0v5ov
ToDo: make DDA support nRanks < 8 case?
Differential Revision: D89249175