Merged
Conversation
meta-cla
bot
added
the
CLA Signed
amirafzali
force-pushed
the
transport-context-refactor
branch
from
8a08905 to
5747b92
Compare
amirafzali
requested review from
LucasLLC,
allenwang28,
daniellepintz and
joecummings
and removed request for
LucasLLC,
allenwang28 and
joecummings
amirafzali
commented
Mar 16, 2026
| # Client-side transport context (mirrors TorchStoreStrategy.transport_context) | ||
| self.transport_context = TransportContext() | ||
|
|
||
|
|
Member
Author
There was a problem hiding this comment.
Changes here are just cus I took this as an opportunity to remove MockTransportContext (which is no longer needed) and use fixtures for setup / teardown
amirafzali
force-pushed
the
transport-context-refactor
branch
from
21eceb0 to
ee64303
Compare
allenwang28
approved these changes
Mar 17, 2026
Contributor
allenwang28
left a comment
allenwang28
left a comment
There was a problem hiding this comment.
This PR encapsulates TransportContext by preventing implementation details of concrete cache patterns from leaking into client code. It enforces a better abstraction so consumers interact with transport caches through a consistent interface rather than accessing them directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A refactor on transport context access to maintain encapsulation of concrete cache patterns
Introduces a type map locator pattern for
TransportContext, and makes underlying caches implementTransportCache(which just ensuresclear()behavior)