[Blackwell] add non-causal bwd/FA with TMA and atomic_add #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manman-ren
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
manman-ren
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
manman-ren
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
manman-ren
changed the title
|
@manman-ren has imported this pull request. If you are a Meta employee, you can view this in D85880773. |
njriasan
approved these changes
Oct 30, 2025
| for blk_idx in range(num_steps): | ||
| q = desc_q.load([(off_bh + curr_m).to(tl.int32), 0]) | ||
| qT = tl.trans(q) | ||
| # Load m before computing qk to reduce pipeline stall. |
Contributor
There was a problem hiding this comment.
Is this still relevant/required with WS?
Contributor
Author
There was a problem hiding this comment.
depending on whether the 1D load of m is in the load partition or not. We can load m first, then wait for qk.
xuzhao9
approved these changes
Oct 30, 2025
Contributor
|
Can you help run |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
manman-ren
force-pushed
the
fa-bwd-b200
branch
from
2bb886a to
6974d4d
Compare
manman-ren
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
manman-ren
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
manman-ren
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
manman-ren
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
manman-ren
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
manman-ren
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Copied from Hongtao's TLX implementation in third_party/tlx/tutorials/blackwell-fa-ws-pipelined-persistent_test.py
Test Plan:
python run.py --op blackwell_attentions --seq-len 8192 --batch 4 --n-heads 32 --d-head 128 --only triton_tutorial_flash_v2_persistent_blackwell --bwd --force --metrics tflops
Reviewers:
Subscribers:
Tasks:
Tags: