argparse #235

monyarm · 2025-04-03T11:18:19Z

feat(mcl): Add commandline argument support
feat(mcl/utils/log): Implement errorAndExit function
feat(mcl/utils/process): Add support to execute function, for supplying redirect; Improve execute function argument escaping, to not escape globs
feat(mcl/config): Implement mcl config command
refactor(mcl/dub): Remove deprecated dflags for improved build configuration
fix(ci_matrix): Initialize params directly in ci_matrix function
fix(utils/cachix): Modify getCachixDeploymenApiUrl definition, to allow compilation with newer d compiler versions.
feat(mcl/main): Integrate argparse for command-line argument parsing and enhance command handling
feat(commands/get_fstab): Enhance get_fstab command with argparse integration and structured argument handling
feat(commands/deploy_spec): Enhance deploy_spec command with argparse integration and structured argument handling
feat(commands/host_info): Enhance host_info command with argparse integration and structured argument handling
feat(commands/config): Enhance config command with argparse integration and structured argument handling
feat(commands/machine): Enhance machine command with argparse integration and structured argument handling
feat(commands): Enhance ci/matrix commands with argparse integration and structured argument handling where applicable

packages/mcl/src/main.d

reo101 · 2025-06-11T06:22:19Z

packages/mcl/src/src/mcl/commands/ci_matrix.d

-export void print_table(string[] args)
+@(Command("print-table", "print_table").Description("Print a table of the cache status of each package"))
+struct print_table_args
+{
+}
+
+export int print_table(print_table_args args)


Can we instead try supporting argument-less commands by providing an aptly argument-less function returning void, with genSubCommandArgs being updated to dynamically check whether or not each sub-command handler function has arguments/return value at all before taking them into account?
This also applies to all _args structs annotated with @(Command(" ").Description(" ")).

I don't think so, as as argparse SubCommands are expressed as SumTypes.

We could actually do something like this:

struct Command1 { // no CLI args int run() { /* ... */ } } struct Command2 { int arg1; string arg2; int run() { // Use `this.arg1` and `this.arg2`... } }

PetarKirov · 2025-11-13T14:17:58Z

packages/mcl/src/src/mcl/commands/config.d

+@(Command("apply").Description("Apply user configuration"))
+struct home_apply_args
+{
+    @(PositionalArgument(0).Placeholder("desktop/server").Description("Type of home configuration"))
+    string type;
+}
+
+@(Command("edit").Description("Edit user configuration"))
+struct home_edit_args
+{
+    @(PositionalArgument(0).Placeholder("desktop/server").Description("Type of home configuration"))
+    string type;
+}


Suggested change

@(Command("apply").Description("Apply user configuration"))

struct home_apply_args

{

@(PositionalArgument(0).Placeholder("desktop/server").Description("Type of home configuration"))

string type;

}

@(Command("edit").Description("Edit user configuration"))

struct home_edit_args

{

@(PositionalArgument(0).Placeholder("desktop/server").Description("Type of home configuration"))

string type;

}

enum HomeConfigType { desktop, server }

@(Command("apply").Description("Apply user configuration"))

struct home_apply_args

{

@(PositionalArgument(0).Placeholder("desktop/server").Description("Type of home configuration"))

HomeConfigType type;

}

@(Command("edit").Description("Edit user configuration"))

struct home_edit_args

{

@(PositionalArgument(0).Placeholder("desktop/server").Description("Type of home configuration"))

HomeConfigType type;

}

PetarKirov · 2025-11-13T14:20:53Z

packages/mcl/src/src/mcl/commands/config.d

 }

-void sys(string[] args)
+int apply(string type, string value)


I suggest having two separate functions:

int switchSystem(string machineName); int switchHome(HomeConfigType type, string username);

The comment about switchHome is dependent on this change in the Justfile:

PetarKirov · 2025-11-13T14:23:56Z

packages/mcl/src/src/mcl/commands/deploy_spec.d


    if (!spec.agents.length)
-        return;
+        return 1;


Having no configurations to deploy is ok:

Suggested change

return 1;

return 0;

PetarKirov · 2025-11-13T14:30:16Z

packages/mcl/src/src/mcl/commands/host_info.d

+    return 1;
+


Suggested change

return 1;

return 0;

packages/mcl/src/src/mcl/commands/host_info.d

PetarKirov · 2025-11-13T14:31:46Z

packages/mcl/src/src/mcl/commands/host_info.d

        .toPrettyString(JSONOptions.doNotEscapeSlashes)
        .writeln();

    if (!params.codaApiToken) {


Suggested change

if (!params.codaApiToken) {

if (args.uploadToCoda && !params.codaApiToken) {

PetarKirov · 2025-11-13T14:34:49Z

packages/mcl/src/src/mcl/commands/machine.d

+    @(NamedArgument(["is-normal-user"]).Placeholder("true/false").Description("Is this a normal user"))
+    bool isNormalUser;


All users are non-system, so we don't need this option.

packages/mcl/src/main.d

…uration

…and enhance command handling

…egration and structured argument handling

… integration and structured argument handling

…egration and structured argument handling

…on and structured argument handling

…tion and structured argument handling

…and structured argument handling where applicable

…nfiguration

… for host info retrieval

…mands

…ine top-level commands

* Switch to nixpkgs version of `buildDubPackage` * Use `nix-to-dub` to generate dub lock file: nix run nixpkgs#dub-to-nix > dub-lock.json * Enable `checkPhase` (default is off in nixpkgs, unlike dlang.nix) * Escape flags disabled tests flag passed to `dubTestFlags` * Add installPhase

…ion" This reverts commit 0fdda48.

github-actions · 2025-11-19T19:06:31Z

Thanks for your Pull Request!

Below you will find a summary of the cachix status of each package, for each supported platform.

package	`x86_64-linux`	`x86_64-darwin`	`aarch64-darwin`
aztec	✅ cached	🚫 not supported	✅ cached
cachix	❌ build failed	❌ build failed	❌ build failed
dcd	✅ cached	🚫 not supported	🚫 not supported
dmd	✅ cached	🚫 not supported	🚫 not supported
dscanner	✅ cached	🚫 not supported	🚫 not supported
dub	✅ cached	✅ cached	✅ cached
erigon	✅ cached	🚫 not supported	🚫 not supported
folder-size-metrics	✅ cached	🚫 not supported	🚫 not supported
foundry	✅ cached	✅ cached	✅ cached
geth	✅ cached	🚫 not supported	✅ cached
ldc	✅ cached	🚫 not supported	🚫 not supported
lido-withdrawals-automation	✅ cached	✅ cached	✅ cached
mcl	✅ cached	🚫 not supported	🚫 not supported
mev-boost	✅ cached	🚫 not supported	🚫 not supported
nethermind	✅ cached	🚫 not supported	🚫 not supported
nimbus	✅ cached	🚫 not supported	🚫 not supported
nix	❌ build failed	❌ build failed	❌ build failed
nix-eval-jobs	❌ build failed	❌ build failed	❌ build failed
nix-fast-build	❌ build failed	❌ build failed	❌ build failed
pyroscope	✅ cached	✅ cached	✅ cached
random-alerts	✅ cached	✅ cached	✅ cached
rustToolchain	✅ cached	✅ cached	✅ cached
secret	✅ cached	🚫 not supported	✅ cached
serve-d	✅ cached	🚫 not supported	🚫 not supported
terraform	✅ cached	🚫 not supported	🚫 not supported
terranix	✅ cached	🚫 not supported	🚫 not supported
web3signer	✅ cached	🚫 not supported	🚫 not supported

monyarm force-pushed the feat/mcl/jcli branch 2 times, most recently from 662b512 to a999476 Compare April 10, 2025 14:55

PetarKirov mentioned this pull request Jun 4, 2025

feat/mcl/config #183

Merged

PetarKirov force-pushed the feat/mcl/jcli branch 2 times, most recently from 9ae8a89 to f67558b Compare June 4, 2025 10:12

reo101 self-requested a review June 4, 2025 15:57

reo101 requested changes Jun 11, 2025

View reviewed changes

MartinNikov force-pushed the main branch from ab6b7ea to 8517b67 Compare July 8, 2025 08:28

PetarKirov force-pushed the main branch 9 times, most recently from 04b4e49 to 65172bd Compare August 6, 2025 01:23

PetarKirov force-pushed the main branch 2 times, most recently from 559a043 to 9ae77e2 Compare August 23, 2025 13:47

monyarm changed the title ~~feat/mcl/jcli~~ argparse Oct 24, 2025

monyarm force-pushed the feat/mcl/jcli branch from f67558b to 4ba1cfe Compare October 24, 2025 16:03

PetarKirov force-pushed the main branch from ee40f74 to 0bf7520 Compare October 31, 2025 15:46

PetarKirov force-pushed the feat/mcl/jcli branch 3 times, most recently from 225118a to 6beef97 Compare November 18, 2025 16:23

PetarKirov requested changes Nov 19, 2025

View reviewed changes

monyarm added 4 commits November 19, 2025 20:59

refactor(mcl/dub): Remove deprecated dflags for improved build config…

6cbb64d

…uration

fix(ci_matrix): Initialize params directly in ci_matrix function

623f84a

feat(mcl/main): Integrate argparse for command-line argument parsing …

3a3a16a

…and enhance command handling

feat(commands/get_fstab): Enhance get_fstab command with argparse int…

a03b3f7

…egration and structured argument handling

monyarm and others added 18 commits November 19, 2025 20:59

feat(commands/deploy_spec): Enhance deploy_spec command with argparse…

f7d0069

… integration and structured argument handling

feat(commands/host_info): Enhance host_info command with argparse int…

d0b5812

…egration and structured argument handling

feat(commands/config): Enhance config command with argparse integrati…

bf243ad

…on and structured argument handling

feat(commands/machine): Enhance machine command with argparse integra…

2556828

…tion and structured argument handling

feat(commands): Enhance ci/matrix commands with argparse integration …

8cd1912

…and structured argument handling where applicable

fix(actions): Correct command names in GitHub workflows and action co…

6081865

…nfiguration

fix(commands/machine): Correct command name in createMachine function…

e174198

… for host info retrieval

feat(mcl): Add command aliases for backwards compatibility

2762e8b

fix(mcl.commands): Fix function signature of ci and ci_matrix com…

dccf6f4

…mands

refactor(mcl.commands): Improve meta-programming to automatically def…

d57c131

…ine top-level commands

fix(mcl.commands.config): Update nixos config repo names

3f5034a

feat(mcl): PascalCase all command arg structs

eeb4628

refactor(mcl.commands): Use selective import for argparse

d25e6e0

style(mcl.commands): Reformat command definition

a5e94f7

refactor(mcl.env): Remove the requirement of a setup function

29722c2

fix(mcl.commands.shard_matrix): Fallback to GITHUB_OUTPUT env variable

9b3032f

Revert "fix(ci_matrix): Initialize params directly in ci_matrix funct…

602bee7

…ion" This reverts commit 0fdda48.

PetarKirov force-pushed the feat/mcl/jcli branch from bd8004c to 602bee7 Compare November 19, 2025 19:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

argparse #235

argparse #235

Uh oh!

monyarm commented Apr 3, 2025

Uh oh!

Uh oh!

Uh oh!

reo101 Jun 11, 2025

Uh oh!

PetarKirov Nov 19, 2025

Uh oh!

PetarKirov Nov 13, 2025

Uh oh!

PetarKirov Nov 13, 2025

Uh oh!

PetarKirov Nov 13, 2025

Uh oh!

PetarKirov Nov 13, 2025

Uh oh!

Uh oh!

PetarKirov Nov 13, 2025

Uh oh!

PetarKirov Nov 13, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	if (!params.codaApiToken) {
	if (args.uploadToCoda && !params.codaApiToken) {

		@(NamedArgument(["is-normal-user"]).Placeholder("true/false").Description("Is this a normal user"))
		bool isNormalUser;

argparse #235

Are you sure you want to change the base?

argparse #235

Uh oh!

Conversation

monyarm commented Apr 3, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants