Draft
Conversation
|
Regarding socket type. https://redmine.openinfosecfoundation.org/issues/250#note-12 -- it looks like there's not much of a difference between using dgrams and stream, since log size usually fits in single packet payload. Also, i tested forwarding from dgram socket and it works(with some modification to the code). |
2ce146f to
9ffc647
Compare
|
@majst01 I'm not sure if it's worth to have separate types for IDS/IPS events. In both cases, logs are written to eve socket. Only difference is in event(action) types. IMO, it's probably better(simpler) to leave only single type(IDS) for both cases. |
Contributor
Author
|
Yes sure, we should forward both events into the same stream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@GrigoriyMikhalkin
TODO:
TODO firewall-controller:
TODO after all above: