Draft
Conversation
…into optional-instead-of-stringvalue
…into optional-instead-of-stringvalue
Gerrit91
added
the
minor
Gerrit91
reviewed
Jul 24, 2025
| Name: "port", | ||
| Value: "5432", | ||
| Usage: "postgres db port", | ||
| EnvVars: []string{"MASTERDATA_PG_PORT"}, |
Contributor
There was a problem hiding this comment.
Try to maintain the old environment variables from the helm chart.
Contributor
|
Looks like we can merge this soon. |
majst01
added
area: control-plane
Contributor
Author
|
This is now completely broken again, maybe @Gerrit91 you can manage to merge that ? |
Contributor
|
Here is a PR: #134 |
* Introduce namespaces for memberships. (#132) * Merge main into connect branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a breaking change in the way all consumers must talk to this service. I would propose to deploy this alongside the masterdata-api and rename it to tenant-api which will also close #34
Alternative approach:
as described in #34, create a new repo
metal-stack/tenant-apiserverand push this branch to that repository. Then deploy thetenant-apiserveralongsidemasterdata-apiand point themetal-apiserverright from the beginning to this instance and let the other consumers gradually migrate to the newtenant-apiserver.Bonus would be to create two repos,
tenant-apiandtenant-apiserverto better separate api and impl.WDYT @Gerrit91 @mwennrich