Add pre-conditions to reject invalid URL inputs#28
Open
mjul wants to merge 1 commit intometosin:masterfrom
Open
Add pre-conditions to reject invalid URL inputs#28mjul wants to merge 1 commit intometosin:masterfrom
mjul wants to merge 1 commit intometosin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pre-conditions to check inputs when creating responses, ensuring that URLs look like URLs.
This improves the developer experience by giving a clear error message rather than an obscure stack trace from the underlying web server infrastructure.
Without this, if you accidentally wrote
(created {:message "OK})the framework would assume that the map is a URL and at a later point explode with a stack-trace like the one below.With this change, it would give you a specific error in the call to
created.