enhancement(metrics-exporter-prometheus): implement native histogram support #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
native-histograms
branch
3 times, most recently
from
264efda to
6a92e79
Compare
tobz
added
C-exporter
alex
force-pushed
the
native-histograms
branch
from
6a92e79 to
a60da26
Compare
…s-exporter-prometheus
alex
force-pushed
the
native-histograms
branch
from
a60da26 to
708cd6f
Compare
tobz
approved these changes
Oct 23, 2025
Member
|
Overall, this seems reasonable to me. I gave it a reasonable review, and it all makes sense to me... but I don't really use Prometheus at all so more subtle issues/pitfalls may have very well eluded me during my review. 😅 |
Contributor
Author
|
Thanks for the review! I'll see if I can find any additional reviewers with deeper familiarity with prom native histograms. |
tobz
changed the title
Member
|
In the interest of getting this out there to be played with, I'm going to merge it as-is. Worst case, someone realizes it's broken and we revert it or fix it. 🤷🏻 |
Contributor
Author
|
Cheers! |
tobz
added
the
S-awaiting-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this draws heavily from the Go and Python implementations -- its definitely possible that I missed some essential details, so I'd appreciate a critical review.
in local testing (using the provided example) with a prometheus server, it seems to work!