(DRAFT) mmn cleanup block ordering #321
Draft
+44
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoangdohuy
reviewed
Oct 13, 2025
p2p/block_ordering.go
Outdated
|
|
||
| // Trigger cleanup after processing blocks - use the latest processed slot | ||
| latestProcessedSlot := processedBlocks[len(processedBlocks)-1].Slot | ||
| ln.cleanupBlockOrderingQueue(latestProcessedSlot) |
Collaborator
There was a problem hiding this comment.
Not sure why we need this clean logic?
Collaborator
Author
There was a problem hiding this comment.
i removed this only clean every 1500 blocks
hoangdohuy
requested changes
Oct 13, 2025
Collaborator
hoangdohuy
left a comment
hoangdohuy
left a comment
There was a problem hiding this comment.
Please review logic again! I not sure why you need this clean logic?
hoangdohuy
requested changes
Oct 13, 2025
Collaborator
hoangdohuy
left a comment
hoangdohuy
left a comment
There was a problem hiding this comment.
Ideally we dont need handle this cleanup.
-> If we need to call cleanupBlockOrderingQueue maybe have something wrong with our logic so please add log warn when start and finish cleanupBlockOrderingQueue function.
hoangdohuy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.