add option to hide coordinates from command output#60
Open
wotnak wants to merge 1 commit intomfnalex:masterfrom
Open
add option to hide coordinates from command output#60wotnak wants to merge 1 commit intomfnalex:masterfrom
wotnak wants to merge 1 commit intomfnalex:masterfrom
Conversation
by default use reducedDebugInfo gamerule to determine if coordinates should be shown allow to explicitly configure if coordinates should be shown or not for players with invunload.coordinates permission always show coordinates regardless of the configured option
wotnak
commented
Jul 1, 2023
|
|
||
| @SuppressWarnings("FieldCanBeLocal") | ||
| private final int currentConfigVersion = 34; | ||
| private final int currentConfigVersion = 37; |
Author
There was a problem hiding this comment.
The new config version is set to 37 instead of just incremented by one because the latest version (5.0.2) published on spigot.org has it set to 36. It looks like the code in repo doesn't contain changes from the v5.0.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
show-coordinatesoption to the config that depending on configured value hides/shows coordinates in commands output.Available configuration values:
default- (default) coordinates will be hidden if reducedDebugInfo gamerule is set to true,true- coordinates will always be shown,false- coordinates will always be hidden.New permission
invunload.coordinatesis also added that allows to always show coordinates for a specific player/group even when the plugin is configured to not show coordinates.Resolves second point from #58. The third point is also effectively resolved since when
show-coordinatesis set tofalseno summaries will be displayed.