Skip to content

feat: Add checkbashisms#916

Open
emilal wants to merge 1 commit intomfussenegger:masterfrom
emilal:feat/checkbashisms
Open

feat: Add checkbashisms#916
emilal wants to merge 1 commit intomfussenegger:masterfrom
emilal:feat/checkbashisms

Conversation

@emilal
Copy link
Copy Markdown

@emilal emilal commented Apr 2, 2026

checkbashisms doesn't have the sort of project page people might expect, but there are at least some manpages available online, e.g. checkbashisms(1) at die.net.

I gave the Debian devscripts page as the upstream because that's what it is, even though it's probably rather opaque for someone discovering it through the list of linters.

`checkbashisms` doesn't have the sort of project page people might
expect, but there are at least some manpages available online, e.g.
[checkbashisms(1) at
die.net](https://linux.die.net/man/1/checkbashisms).
@@ -0,0 +1,17 @@
return {
cmd = "checkbashisms",
stdin = false, -- Does not take stdin unless we give "-" as an arg
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to set this to true and add the - arg?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, I just don't know what your preference here is. I think either is fine. If you want I can swap it to stdin mode?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(If so I'm probably also going to replace %f in the parser with (stdin) since I see no need to spend effort parsing a static string)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lined up a meta-PR so I can click the button here if that's the preferred way of doing things
emilal#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants