Make it possible to get arguments and field name#83
Open
eiriksm wants to merge 6 commits intomghoneimy:masterfrom
Open
Make it possible to get arguments and field name#83eiriksm wants to merge 6 commits intomghoneimy:masterfrom
eiriksm wants to merge 6 commits intomghoneimy:masterfrom
Conversation
Author
|
I'm torn between trying to follow the style in the test class here and the feedback from CI systems, so I will just say that this seems to be good enough, and close enough to the initial code style :) |
|
Especially the fieldname getter interests me as well. It would allow me to implement a simple generic pagination method by extracting the fieldname so I can do something like $fieldName = $query->fieldname;
$items = $client->runQuery($query)->getResults();
$hasNextPage = $items->data->$fieldName->pageInfo->hasNextPage;
$after = $items->data->$fieldName->pageInfo->endCursor; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this library. For me it's super important to represent the query as an object, and this library seems to do the trick nicely. However, it's missing 2 things I need, which this PR adds:
A getter for field name and a getter for arguments.
First. Here is a simple program to illustrate why I want a getter for arguments:
And here is why I want the getter for field name: