Add PHPStan #53
Draft
Add PHPStan #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Owner
|
Is this PR still a draft? |
This will allow using PHPStan to detect bugs in both FeedWriter and projects using it. Additionally, it will provide better information for IDEs.
Do not special case storage of unique elements, just overwrite them at insertion if present. This will make it easier for both PHPStan and programmer to reason about.
This is static analysis tool. It can be executed using `composer phpstan`.
Contributor
Author
|
There are still 18 errors. Some of them are actually false positives, mainly stemming from overuse of arrays, other are strict_types violation or |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.